Conversation
Zadamsa
force-pushed
the
list_detector
branch
3 times, most recently
from
f6c8841 to
5becd18
Compare
Zadamsa
force-pushed
the
list_detector
branch
6 times, most recently
from
c66e344 to
6ce0b66
Compare
Zadamsa
force-pushed
the
list_detector
branch
2 times, most recently
from
0b8a985 to
bbc6b30
Compare
Zadamsa
force-pushed
the
list_detector
branch
from
bbc6b30 to
aca1ad9
Compare
SiskaPavel
reviewed
Nov 7, 2024
|
|
||
| #pragma once | ||
|
|
||
| #include "rule.hpp" |
Collaborator
There was a problem hiding this comment.
Soubor rule.hpp v tomto case neexistuje
| } | ||
| } | ||
| for (const auto& ruleField : ruleFields) { | ||
| if (Rule::isStringType(ruleField.first)) { |
Collaborator
There was a problem hiding this comment.
Zbytecne 2 for cykly, slo by to spojit
Zadamsa
force-pushed
the
list_detector
branch
4 times, most recently
from
e844c82 to
87f8658
Compare
Collaborator
|
Zmeril jsem vykonnost pri praci s regexi a tvuj modul byl asi o 25% rychlejsi nez predchozi implementace. |
Zadamsa
force-pushed
the
list_detector
branch
2 times, most recently
from
b329f62 to
a9acf3e
Compare
Contributor
|
Testy jsou nyní v root adresáři projektu. Je potřeba tyto testy přesunout do adresáře s list detektorem. |
Zadamsa
force-pushed
the
list_detector
branch
4 times, most recently
from
5636d70 to
6e3752b
Compare
Zadamsa
force-pushed
the
list_detector
branch
3 times, most recently
from
b45997a to
82c73f7
Compare
Zadamsa
force-pushed
the
list_detector
branch
2 times, most recently
from
ea869a4 to
df7bce7
Compare
Zadamsa
force-pushed
the
list_detector
branch
2 times, most recently
from
f6ea8de to
2a8c725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.