Conversation
- Implement energy-based VAD node - Add VoiceActivity message type - Create launch file for audio capture with VAD - Update documentation with VAD usage instructions and parameters
Closed
Hoog-V
requested changes
Apr 13, 2025
Member
Hoog-V
left a comment
Hoog-V
left a comment
There was a problem hiding this comment.
Fix the above listed things and the needed things to pass workflow checks, because it will break things if I merge it right now. That's why the checks fail :)
Hoog-V
approved these changes
Apr 13, 2025
Member
Hoog-V
left a comment
Hoog-V
left a comment
There was a problem hiding this comment.
It looks great, when checks done it will be ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an energy-based Voice Activity Detection (VAD) node to the ROS2_Audio_Tools package. For more advanced detection in challenging environments, consider integrating a machine learning-based VAD algorithm.
Features Added
VoiceActivity.msgmessage type for publishing detection resultsImplementation Details
Testing Done
Documentation