Add a required_callback to inject user defined requirement checks#1213
Open
VolkerChristian wants to merge 1 commit intoCLIUtils:mainfrom
Open
Add a required_callback to inject user defined requirement checks#1213VolkerChristian wants to merge 1 commit intoCLIUtils:mainfrom
VolkerChristian wants to merge 1 commit intoCLIUtils:mainfrom
Conversation
In some situations the standard requirement checks are not sufficient. In such cases the user can provide a required_callback doing additional requirement checks. This callback is executed after all standard requirement checks.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 17 19 +2
Lines 4546 5247 +701
Branches 0 1067 +1067
===========================================
+ Hits 4546 5246 +700
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
will need a few test cases and some documentation. Do you have an example use case that is driving this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some situations the standard requirement checks are not sufficient. In such cases the user can provide a required_callback doing additional requirement checks. This callback is executed after all standard requirement checks.