Open
Conversation
Xeno852
requested changes
Feb 28, 2024
Contributor
Xeno852
left a comment
Xeno852
left a comment
There was a problem hiding this comment.
LGTM except you should lint before merging. Can you try to see if you are able to properly lint while maintaining the same functionality?
To lint run:
npm run lint
Or
npm run lint --fix
If you would like to automatically fix most of the issues.
utkanuygur
approved these changes
Mar 1, 2024
Contributor
utkanuygur
left a comment
utkanuygur
left a comment
There was a problem hiding this comment.
After extensively reviewing testing the new features, I approve and endorse the pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMG_9559.MOV