Fix warmup phase statistics and multicore CPU handling#2
Open
konkanello wants to merge 1 commit intomasterfrom
Open
Fix warmup phase statistics and multicore CPU handling#2konkanello wants to merge 1 commit intomasterfrom
konkanello wants to merge 1 commit intomasterfrom
Conversation
konkanello
commented
Dec 10, 2025
- Fix ROI stats reporting: use roi_instr/roi_cycle for simulation phases and sim_instr/sim_cycle for warmup phases
- Fix end_phase() to only update roi_stats during simulation (not warmup)
- Only call end_phase for the CPU that actually finished
- Add trace file extensions to .gitignore (*.xz, *.gz, *.trace)
- Update default config to 2 cores for testing multicore scenarios
- Fix ROI stats reporting: use roi_instr/roi_cycle for simulation phases and sim_instr/sim_cycle for warmup phases - Fix end_phase() to only update roi_stats during simulation (not warmup) - Only call end_phase for the CPU that actually finished - Add trace file extensions to .gitignore (*.xz, *.gz, *.trace) - Update default config to 2 cores for testing multicore scenarios
|
I would suggest retaining the roi_stat update for both warmup and sim phase in end_phase, that way roi_instr() and roi_cycle() can be used universally for printing out final stats at the end of any phase (should simplify your code in champsim.cc nicely). The original intent behind this system was that roi would hold the final results of a phase while sim_stats would hold the in-progress phase stats. This made more sense when our original goal was to have many user-defined phases for the simulation. Warmup was the initial phase, and was treated differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.