Added ColorIndex and basic implementations#5
Open
GeorgeMuscat wants to merge 2 commits intoCOMP6991UNSW:mainfrom
Open
Added ColorIndex and basic implementations#5GeorgeMuscat wants to merge 2 commits intoCOMP6991UNSW:mainfrom
GeorgeMuscat wants to merge 2 commits intoCOMP6991UNSW:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a public
ColorIndexenum that has implementations for multiple traits to allow for easy conversions between colors and usize. The following are implemented:From<ColorIndex> for ColorFrom<ColorIndex> for usizeTryFrom<usize> for ColorIndexTryFrom<u64> for ColorIndexTryFrom<Color> for ColorIndexI believe this enum and the implementations are extremely useful for unsvg users as it maintains backwards compatibility while providing a self documenting interface that is easier to work with.
Please let me know if there is any issue :)
Resolves #6