You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We won't need the cice_from_mom step after the next ACCESS-OM3 release, so i suggest we just revert to numpy 1. We may not need this package going forward, otherwise well need to update the ocean_model_grid_generator to use numpy 2 before we use this.
hm, ok but np.NAN appears in many places in the code, so I expect there will be things other than cice_from_mom that break under numpy 2 - are we happy to stay on numpy 1 indefinitely?
I think we won't really need this package once we stop using the CICE grid file (e.g. from the next OM3 release - 0.4.0) and its safe to assume itll work for a couple of years still with numpy 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #21