Remove ERA-5 fliplat command and assert checks in base_grid.py to sup…#5
Open
rmholmes wants to merge 1 commit intoCOSIMA:mainfrom
Open
Remove ERA-5 fliplat command and assert checks in base_grid.py to sup…#5rmholmes wants to merge 1 commit intoCOSIMA:mainfrom
rmholmes wants to merge 1 commit intoCOSIMA:mainfrom
Conversation
…port latitude reverse ordering in ERA-5.
Contributor
Contributor
|
I think we should move the assert statements to a test, and test based on the grid type. I.e. for most grids. " # The bottom latitude band should always be Southern extent." is a true statement but for ERA5, the opposite is true. Saying that, many grids don't need these corner points, so the code is not actually relevant for ERA5 grids? I don't understand enough about the remapping in OM2 to know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…port latitude reverse ordering in ERA-5.
Should I do something better than just removing the checks?