Allow static libs

[hefroy]

• Remove SHARED option from add_library to allow static libs, CMake then respects the standard BUILD_SHARED_LIBS option.
• Set the default value of BUILD_SHARED_LIBS to ON.
• Modify plugin_manager_impl to call the plugin init function for built-in plugins via a hook, whilst still supporting external shared library plugins.
• Add plugin init hook function to each built-in plugin.
• Add plugin libs to link libs in CMake export config when static libs are enabled.

[goncaloalmeida]

we will check this change internally to see if this is causing any other problems
@hefroy coul dyou please rebase your PR to last version of vsomeip-lib? Thanks!
cc @fcmonteiro @DiogoPedrozza

[goncaloalmeida]

please rebase/fix merge issues

[hefroy]

Rebased ✔️

[goncaloalmeida]

Rebased ✔️

thanks! I will test this PR internally.

[goncaloalmeida]

These changes are not building on the windows env.:
CMake Error at test/network_tests/CMakeLists.txt:4264 (add_dependencies): The dependency target "routingmanagerd" of target "build_network_tests" does not exist.

[hefroy]

These changes are not building on the windows env.: CMake Error at test/network_tests/CMakeLists.txt:4264 (add_dependencies): The dependency target "routingmanagerd" of target "build_network_tests" does not exist.

This seemed to be caused by some other issue on the master branch when I last rebased the branch. I've just rebased it again and now I don't see that CMake error and for me the Windows build compiles ok.

[kheaactua]

I created a similar patch for 3.1.20, I was never really happy with it, but maybe we can compare patches.

I don't remember all the details right now, but my CMake changes were much more extensive, and I had to fix the way the singletons (logger, security, etc) were created and remove any lib constructor/destructor. In the end it seemed to work but I had a segfault on exit in examples/routingmanagerd

[kheaactua]

I created a similar patch for 3.1.20, I was never really happy with it, but maybe we can compare patches.

I don't remember all the details right now, but my CMake changes were much more extensive, and I had to fix the way the singletons (logger, security, etc) were created and remove any lib constructor/destructor. In the end it seemed to work but I had a segfault on exit in examples/routingmanagerd

I think the most recent vsomeip release only has [one lib destructor here](https://github.com/search?q=repo%3ACOVESA%2Fvsomeip+__attribute__&type=code, CommonAPI (capicxx-core-runtime) has two lib constructors though (not sure if you're using CommonAPI)

Looking at the vsomeip one, it could probably be ignored..

[hefroy]

@kheaactua:

In the end it seemed to work but I had a segfault on exit in examples/routingmanagerd

I also found the same, and have opened #789 separately to fix a couple of use-after-free destruction order issues.
I've just rebased this PR to master and tested it again with #789 also applied - routingmanagerd shuts down without segfault.

Looking at the vsomeip one, it could probably be ignored

Agreed.

CommonAPI (capicxx-core-runtime) has two lib constructors though (not sure if you're using CommonAPI)

Yes I am also using CommonAPI and have two PRs for adding static library support - probably better to discuss those over there:
COVESA/capicxx-core-runtime#42
COVESA/capicxx-someip-runtime#27

[hefroy]

For reference, this patch is being used over in https://github.com/aws/aws-iot-fleetwise-edge
See the patch file here: https://github.com/aws/aws-iot-fleetwise-edge/blob/a6bfb5176eb0a954b436473802de3221b815be7e/tools/patches/vsomeip_allow_static_libs_fix_shutdown_segfaults.patch