framerate config #46
framerate config #46
Conversation
jujuz455
force-pushed
the
feat/add-framerate-config
branch
from
ecb299b to
6679562
Compare
|
I haven't forgotten about this one but I can't test it until I am back in Ottawa. |
haha it's ok i'm not back either, but if I want to test it myself, can I connect my laptop to the rover, or does it have to be Windows? |
You can absolutely connect to it via your laptop but there are a few steps to do it. You need to connect to the rover via a ethernet cable (the rover has a port on the side). Set your IP address manually to something on the 192.168.0.X subnet. Then you can use SSH via VS code get onto the rover. Make sure to launch a dev container via the jetson config within VS Code on the rover. It is not super hard but a little complicated the first time. Maybe the first week back I will do a demo for the full Software team. |
jujuz455
force-pushed
the
feat/add-framerate-config
branch
from
6679562 to
81025dc
Compare
jujuz455
force-pushed
the
feat/add-framerate-config
branch
from
81025dc to
016893b
Compare
ConnorNeed
left a comment
ConnorNeed
left a comment
There was a problem hiding this comment.
Thanks Runchen! We will test this tomorrow. Good luck in the shop as well
| } | ||
|
|
||
| SrtNode::~SrtNode() { | ||
| auto cleanup_element = [](GstElement *&elem) { |
There was a problem hiding this comment.
Love this use of a lambda. However this fuction might be usefull in many places. Maybe it could be a static protected member function in the base class?
|
|
||
| bool test_mode = this->get_parameter("test_mode").as_bool(); | ||
|
|
||
| int default_fps = this->get_parameter("target_framerate").as_int(); |
There was a problem hiding this comment.
It's not really a default value. Can we just rename to 'framerate' or 'framerate_fps'?
| GstCaps *caps = gst_caps_new_simple("video/x-raw", "framerate", | ||
| GST_TYPE_FRACTION, new_fps, 1, NULL); | ||
|
|
||
| g_object_set(framerate_caps_, "caps", caps, NULL); |
There was a problem hiding this comment.
We might have to set the pipeline to paused before changing this but we can test that tommorrow.
* feat: implement backoff mechanism for I-frame requests and enhance SrtStats message * refactor: standardize variable naming in BackoffState struct * feat: introduce configurable backoff parameters and enhance stability checks
Added a configurable framerate parameter to the SrtNode