Skip to content

Completing Listing REST endpoints for GET all and POST#7

Open
Amormio25 wants to merge 7 commits intomainfrom
listings_svc
Open

Completing Listing REST endpoints for GET all and POST#7
Amormio25 wants to merge 7 commits intomainfrom
listings_svc

Conversation

@Amormio25
Copy link
Collaborator

Describe your changes

  • wrote code for getting all listings in db (GET all)
  • wrote code for creating a new listing in db (POST)
  • fixed requested changes and renamed branch for all work relating to listings

Issue ticket number and link

[ Insert Link & Ticket #]

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • This change requires a documentation update

Copy link
Collaborator

@arnavjk007 arnavjk007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also have it where only certain roles can create listings or ping these APIs. So just keep note or maybe comment as a reminder to implement user auth and permissions once that is implemented. For example, only lab admins can create or delete listings so we need to check permissions before we do the process.

Copy link
Collaborator

@arnavjk007 arnavjk007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes + sorting changes

…now, created indexing for filters in schema file
Copy link
Collaborator

@arnavjk007 arnavjk007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restructuring change for consistency across all services

Copy link
Collaborator

@arnavjk007 arnavjk007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes

Copy link
Collaborator

@arnavjk007 arnavjk007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I think the final thing we need is a little bit of unit testing to make sure that the apis work properly. I set up jest on the main branch so make sure to do git merge main in your feat branch to get the updates. Unit testing goes into each folder and creates a new tests file with .test.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants