Open
Conversation
arnavjk007
requested changes
Feb 17, 2026
| return NextResponse.json({ message: "Invalid ID" }, | ||
| { status: 400 }); | ||
| } | ||
| const item = await getLab(parsedParams.data.id); |
Collaborator
There was a problem hiding this comment.
This is good but let's update this to return a list of labs when we pass in user id. Because what if a user is a part of multiple labs?
| */ | ||
| export async function getLabs(): Promise<Lab[]> { | ||
| await connectToDatabase(); | ||
| const labs = await LabModel.find().exec(); |
Collaborator
There was a problem hiding this comment.
lets also add .lean() and .sort({ createdAt: -1 }) to ensure labs returned will always be in same order
| */ | ||
| export async function getLab(id: string): Promise<Lab | null> { | ||
| await connectToDatabase(); | ||
| const lab = await LabModel.findById(id).exec(); |
| // Could be used accidentally or misused maliciously to get rid of important data | ||
| export async function deleteLab(id: string): Promise<boolean> { | ||
| await connectToDatabase(); | ||
| const deleted = await LabModel.findByIdAndDelete(id).exec(); |
Collaborator
There was a problem hiding this comment.
Let's try to do this format where we get the item and then check if it exists. If it doesn't then we return item not found otherwise we return it like this:
const item = await LabModel.findById(id).exec();
if (!item) {
throw new NotFoundError("Item not found");
}
await item.deleteOne();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
[ Couple of bullet points ]
Issue ticket number and link
[ Insert Link & Ticket #]
Checklist before requesting a review