feat: add multiline wrapping to GtxRenderer#2
Closed
lkristensen wants to merge 11 commits intoCaptainFrito:feature/lyra-screensfrom
Closed
feat: add multiline wrapping to GtxRenderer#2lkristensen wants to merge 11 commits intoCaptainFrito:feature/lyra-screensfrom
lkristensen wants to merge 11 commits intoCaptainFrito:feature/lyra-screensfrom
Conversation
Added the function wrappedText to GtxRenderer, that returns a vector of strings that do not exceed the with specified. You can specify a max number of lines, and if it that number is exceeded the rest of the text is truncated using truncatedText. An example implementation has been added to LyraTheme for the title.
CaptainFrito
force-pushed
the
feature/lyra-screens
branch
8 times, most recently
from
4bed383 to
867af15
Compare
Owner
CaptainFrito
left a comment
CaptainFrito
left a comment
There was a problem hiding this comment.
Dude this is great! Sorry I've been force pushing to my branch so it looks like it messed up your branch. Would you be able to rebase it?
Better yet, you should create your PR on dave's repo, that way you can appear in the contributors.
CaptainFrito
force-pushed
the
feature/lyra-screens
branch
2 times, most recently
from
ca453b1 to
cec922f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added the function wrappedText to GtxRenderer, that returns a vector of strings that do not exceed the with specified. You can specify a max number of lines, and if it that number is exceeded the rest of the text is truncated using truncatedText.
An example implementation has been added to LyraTheme for the title.
Additional Context
Before:
After:
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? Consulted chatGPT on return types in ESP32 environment