Skip to content

Conversation

@bernardodsanderson
Copy link
Collaborator

CP-11565

Overview

This pull request enhances the audit logging capabilities within DocuSeal to granularly track user actions and data changes.

Key Changes:

  • User Attribution: Added user_id to SubmissionEvent to identify exactly who performed an action.
  • Granular Change Tracking: Implemented a new form_update event type that records specific field changes, capturing both previous and new values (from -> to).
  • Enhanced Exports & Webhooks: Updated ExportSubmissionService and SendFormCompletedWebhookRequestJob to include detailed form values and the full submission event history in their outputs.
  • Refactoring: Updated controllers and services to propagate the current_user context for accurate tracking.
  • Testing: Added specs to verify the correct recording of form field updates and data integrity in exports.

Loom

https://www.loom.com/share/f490ab8db5c74398b21ef80b64ed4336

This pull request enhances the audit logging capabilities within DocuSeal to granularly track user actions and data changes.

  Key Changes:

   * User Attribution: Added user_id to SubmissionEvent to identify exactly who performed an action.
   * Granular Change Tracking: Implemented a new form_update event type that records specific field changes, capturing both previous and new values (from -> to).
   * Enhanced Exports & Webhooks: Updated ExportSubmissionService and SendFormCompletedWebhookRequestJob to include detailed form values and the full submission event history in their outputs.
   * Refactoring: Updated controllers and services to propagate the current_user context for accurate tracking.
   * Testing: Added specs to verify the correct recording of form field updates and data integrity in exports.
Remove two duplicate test cases that verify basic webhook request sending
functionality. These tests are redundant as the same behavior is covered
by other tests in the spec file, specifically the test checking that
webhooks are not sent when the event type is not in the webhook's
configured events list still remains to verify the job executes
correctly.
Copy link

@jewls618 jewls618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, just left a few non-blocking comments.

@bernardodsanderson bernardodsanderson merged commit 48d4d25 into main Feb 4, 2026
5 checks passed
@bernardodsanderson bernardodsanderson deleted the CP-11565 branch February 4, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants