CP-12003 / add scroll and highlight #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jewls618
requested review from
bernardodsanderson,
ryanarakawa and
spaulsandhu
bernardodsanderson
approved these changes
Feb 2, 2026
Collaborator
bernardodsanderson
left a comment
bernardodsanderson
left a comment
There was a problem hiding this comment.
Looks great!
Nit: When I clicked on the fields, the left side highlights move the fields a bit because of the added border. One thing you can do about that is to use padding/margin/size to negate the border size. Not a huge deal either way!
Comment on lines
1727
to
1728
| scrollToArea (area) { | ||
| const documentRef = this.documentRefs.find((a) => a.document.uuid === area.attachment_uuid) | ||
| const documentRef = this.documentRefs.find((a) => a.document.uuid === area.attachment_uuid) |
Collaborator
There was a problem hiding this comment.
Nit: this indentation is different from the next lines in scrollToArea.
| // Wait for submitter switch to complete | ||
| this.$nextTick(() => { | ||
| // Scroll field into view in sidebar | ||
| this.$refs.fields.scrollFieldIntoView(field) |
Collaborator
There was a problem hiding this comment.
Not sure if needed, but we could have a null check on here (this.$refs.fields) before calling the scrolling, just to make sure it won't break anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: CP-12003
Description
Adds functionality where clicking on a field in the document preview causes the left-hand sidebar to scroll to that field and highlight it, similar to the existing eDoc builder behavior.
Changes
scrollFieldIntoSidebarDemo
https://www.loom.com/share/9bf7ecf8522d4cc6aea504978f8ced8f