Disable 'Create' button when required fields are missing in the Upsert Experiment modal #2794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Experiment modal
danoswaltCL
reviewed
Dec 11, 2025
| combineLatestWith( | ||
| this.isInitialFormValueChanged$, | ||
| this.experimentForm.statusChanges.pipe(startWith(this.experimentForm.status)) | ||
| ), |
Collaborator
There was a problem hiding this comment.
i've actually made a similar change in my PR to put the ts_config in there, thing is we don't need to combine and query the statusChanges observable, simply !experimentForm.valid will give the same thing
Collaborator
Author
There was a problem hiding this comment.
OK, should I close this one then?
Collaborator
There was a problem hiding this comment.
sure if you agree and see it working as you expect in my mooclet PR, yeah it can close
Collaborator
Author
|
Closing this because #2793 resolves it in a simpler way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2789