Skip to content

metrics card on the data tab #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bcb37 wants to merge 1 commit into
base: experiment-design-refresh
Choose a base branch
from
Open

metrics card on the data tab #2803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .../experiment-metrics-data-section-card/experiment-metrics-data-section-card.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,9 @@
</app-common-section-card-action-buttons>

<!-- content -->
<app-experiment-metrics-data content *ngIf="isSectionCardExpanded"></app-experiment-metrics-data>
<app-experiment-metrics-data
content
[experiment]="experiment"
*ngIf="isSectionCardExpanded"
></app-experiment-metrics-data>
</app-common-section-card>
2 changes: 1 addition & 1 deletion ...-metrics-data-section-card/experiment-metrics-data/experiment-metrics-data.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div class="data-container">
<p>experiment-metrics-data works!</p>
<experiment-query-result [experiment]="experiment"></experiment-query-result>
</div>
8 changes: 5 additions & 3 deletions ...nt-metrics-data-section-card/experiment-metrics-data/experiment-metrics-data.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import { ChangeDetectionStrategy, Component } from '@angular/core';
import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
import { CommonModule } from '@angular/common';
import { TranslateModule } from '@ngx-translate/core';
import { ExperimentQueryResultComponent } from '../../../../../../home/components/experiment-query-result/experiment-query-result.component';
import { ExperimentVM } from '../../../../../../../../core/experiments/store/experiments.model';

@Component({
selector: 'app-experiment-metrics-data',
imports: [CommonModule, TranslateModule],
imports: [CommonModule, TranslateModule, ExperimentQueryResultComponent],
templateUrl: './experiment-metrics-data.component.html',
styleUrl: './experiment-metrics-data.component.scss',
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class ExperimentMetricsDataComponent {
// TODO: Implement metrics data functionality
@Input() experiment: ExperimentVM;
}
4 changes: 0 additions & 4 deletions .../dashboard/home/components/experiment-query-result/experiment-query-result.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
<div class="experiment-queries-result">
<span class="ft-24-700 metric-data-text">{{ 'home.experiment-query-result.title.text' | translate }}</span>
<span class="ft-12-600 metric-data-detail-text">{{ 'home.experiment-query-result.detail.text' | translate }}</span>
<br />
<br />
<span class="ft-18-700 main-effect-data-text">{{
'home.experiment-query-result.main-effect.title.text' | translate
}}</span>
Expand Down
8 changes: 6 additions & 2 deletions ...es/dashboard/home/components/experiment-query-result/experiment-query-result.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ import { Subscription } from 'rxjs';
import { filter } from 'rxjs/operators';
import { EXPERIMENT_STATE, EXPERIMENT_TYPE } from 'upgrade_types';
import { ExperimentFactorData } from '../../../../../core/experiment-design-stepper/store/experiment-design-stepper.model';
import { CommonModule } from '@angular/common';
import { TranslateModule } from '@ngx-translate/core';
import { NgxChartsModule } from '@swimlane/ngx-charts';

interface FactorColumnDef {
name: string;
Expand All @@ -31,10 +34,11 @@ interface RowData {
}

@Component({
selector: 'home-experiment-query-result',
selector: 'experiment-query-result',
templateUrl: './experiment-query-result.component.html',
styleUrls: ['./experiment-query-result.component.scss'],
standalone: false,
standalone: true,
imports: [CommonModule, TranslateModule, NgxChartsModule],
})
export class ExperimentQueryResultComponent implements OnInit, OnDestroy {
@Input() experiment: ExperimentVM;
Expand Down
1 change: 0 additions & 1 deletion frontend/projects/upgrade/src/app/features/dashboard/home/home.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ import { MoocletPolicyEditorComponent } from './components/experiment-design/moo
ImportExperimentComponent,
QueriesModalComponent,
CreateQueryComponent,
ExperimentQueryResultComponent,
ExperimentEndCriteriaComponent,
RepeatedMeasurePipe,
StateTimeLogsComponent,
Expand Down