Document logger parameter in TwigFactory for future use#2287
Document logger parameter in TwigFactory for future use#2287ArnaudLigny merged 4 commits intophp-difrom
Conversation
Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot do not remove this code: document it for a future use, to stay consistant. |
Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
Done! I've restored the logger parameter and added documentation explaining it's reserved for future use to stay consistent with other factory patterns. Commit: c335059
Done! I've restored the logger parameter and added documentation explaining it's reserved for future use to stay consistent with other factory patterns. Commit: c335059 |
There was a problem hiding this comment.
Pull request overview
This pull request restores the LoggerInterface $logger parameter to the TwigFactory constructor that was previously removed, adding documentation to explain it's reserved for future use and consistency with other factory patterns.
Changes:
- Added PHPDoc comment explaining the logger parameter is reserved for future use
- Restored the logger parameter property declaration with documentation
- Added blank lines around the logger property for better code formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changes proposed in this pull request:
Added documentation to the
LoggerInterface $loggerparameter inTwigFactory's constructor to clarify that it is reserved for future use and to maintain consistency with other factory patterns in the codebase.Changes:
$loggerproperty explaining it is reserved for future useThe logger parameter is retained and properly documented, even though it is not currently used in the
create()method, to ensure consistency across the codebase and to facilitate future enhancements.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.