Add comprehensive integration tests for PHP-DI container functionality#2290
Merged
ArnaudLigny merged 11 commits intophp-difrom Jan 19, 2026
Merged
Add comprehensive integration tests for PHP-DI container functionality#2290ArnaudLigny merged 11 commits intophp-difrom
ArnaudLigny merged 11 commits intophp-difrom
Conversation
Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
…var handling Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the PHP-DI dependency injection integration in Cecil. It introduces a new test suite that verifies container initialization, service resolution, attribute-based injection, and the full build lifecycle with dependency injection.
Changes:
- Added ContainerFactoryTest.php with 14 test methods covering DI container functionality
- Updated phpunit.xml.dist to include the new ContainerFactoryTests suite
- Tests verify core DI functionality including service resolution, lazy loading, factory definitions, and build process integration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| tests/ContainerFactoryTest.php | New comprehensive test suite for DI container functionality with 14 test methods covering container creation, service resolution, production/debug modes, and full build integration |
| phpunit.xml.dist | Added new ContainerFactoryTests suite configuration to run the new test file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] WIP Address feedback on integrating PHP-DI for dependency injection
Add comprehensive integration tests for PHP-DI container functionality
Jan 19, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…cache test Co-authored-by: ArnaudLigny <80580+ArnaudLigny@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Test Coverage
Added
tests/ContainerFactoryTest.phpwith 14 integration tests verifying:Configuration
Updated
phpunit.xml.distto include ContainerFactoryTests suite.Test Quality Improvements
putenv('CECIL_DEBUG=false')testBuilderIsInContainerinstead oftestAttributeBasedInjectionWithBuilder)Tests use existing fixtures and follow established patterns similar to IntegrationTests.php.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.