Open
Conversation
dwr-zroy
added
the
cleaning up
dwr-bli
reviewed
Mar 3, 2026
Contributor
There was a problem hiding this comment.
I noticed ${USER_PATTERN} is referenced in the Console PatternLayout, but it is not defined in this file.
While Log4j2 may tolerate undefined properties depending on version, I’d prefer we keep the config self-contained and avoid referencing undefined variables.
Can we either define USER_PATTERN or switch to ${TEST_PATTERN}?
Use `RollingFile`, update test for log creation
dwr-zroy
force-pushed
the
feature/test-logs-to-rolling-file
branch
from
1565ea9 to
0049a06
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Align the logging that occurs during tests with the logging framework used by the rest of WRIMS Engine. Add log4j configuration files:
wrims-engine/src/test/resources/log4j2.xmlwrims-comparison-test/src/test/resources/log4j2.xml