Skip to content

[DPEDE-6370] Add Location styles#1950

Open
wojciechwlodarczyklumen wants to merge 3 commits intoCenturyLink:masterfrom
wojciechwlodarczyklumen:DPEDE-6370-create-location-component-styles
Open

[DPEDE-6370] Add Location styles#1950
wojciechwlodarczyklumen wants to merge 3 commits intoCenturyLink:masterfrom
wojciechwlodarczyklumen:DPEDE-6370-create-location-component-styles

Conversation

@wojciechwlodarczyklumen
Copy link
Contributor

This pull request introduces a new location component and integrates its SCSS styles and theme variables across all supported themes. The changes ensure that the location component is available and styled consistently in each theme, with theme-specific variables for layout and spacing. Additionally, the SRI hashes are updated to reflect the new build outputs.

Component Addition and Integration

  • Added new location component SCSS (location.scss) with layout and spacing rules for .chi-location, .chi-location__field, and .chi-location__row.
  • Imported the new location component in all theme entry files (index.scss) to ensure it's included in every theme: brightspeed, centurylink, colt, connect, lumen, portal, and test. [1] [2] [3] [4] [5] [6] [7]

Theme Variable Updates

  • Introduced new SCSS variables for the location component (e.g., $location-field-add-button-margin, $location-field-display, etc.) in each theme's _variables.scss file to allow theme-specific customization of the component's layout and spacing. [1] [2] [3] [4] [5] [6] [7]

Build and Integrity Updates

  • Updated SRI hashes in sri.json to match the new build outputs that include the location component and its styles. [1] [2]

Other Minor Formatting Improvements

  • Reformatted some multi-line SCSS expressions in test/_variables.scss for readability (e.g., box-shadow and calc expressions). [1] [2] [3] [4] [5]

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new location component to the design system with consistent styling across all supported themes. The component includes layout and spacing rules for location fields and rows, with theme-specific customization through SCSS variables.

Changes:

  • Added new location component with SCSS styles and imported it into all theme entry files
  • Introduced location-specific SCSS variables in all theme _variables.scss files for consistent customization
  • Updated SRI hashes to reflect the new build outputs

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

File Description
sri.json Updated SRI hashes for all theme CSS files to reflect inclusion of location component
src/chi/components/location/location.scss New component file defining layout and spacing styles for location fields and rows
src/chi/themes/*/index.scss Added location component import to all 7 theme entry files
src/chi/themes/*/_variables.scss Added location-specific SCSS variables to all 7 theme variable files

@lumen-jenkins-prod
Copy link

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1950/1/. ❌

@lumen-jenkins-prod
Copy link

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1950/2/. ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments