[DPEDE-6370] Add Location styles#1950
Open
wojciechwlodarczyklumen wants to merge 3 commits intoCenturyLink:masterfrom
Open
[DPEDE-6370] Add Location styles#1950wojciechwlodarczyklumen wants to merge 3 commits intoCenturyLink:masterfrom
wojciechwlodarczyklumen wants to merge 3 commits intoCenturyLink:masterfrom
Conversation
…ocation-component-styles
There was a problem hiding this comment.
Pull request overview
This PR adds a new location component to the design system with consistent styling across all supported themes. The component includes layout and spacing rules for location fields and rows, with theme-specific customization through SCSS variables.
Changes:
- Added new
locationcomponent with SCSS styles and imported it into all theme entry files - Introduced location-specific SCSS variables in all theme
_variables.scssfiles for consistent customization - Updated SRI hashes to reflect the new build outputs
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sri.json | Updated SRI hashes for all theme CSS files to reflect inclusion of location component |
| src/chi/components/location/location.scss | New component file defining layout and spacing styles for location fields and rows |
| src/chi/themes/*/index.scss | Added location component import to all 7 theme entry files |
| src/chi/themes/*/_variables.scss | Added location-specific SCSS variables to all 7 theme variable files |
|
The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1950/1/. ❌ |
|
The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-1950/2/. ❌ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
locationcomponent and integrates its SCSS styles and theme variables across all supported themes. The changes ensure that thelocationcomponent is available and styled consistently in each theme, with theme-specific variables for layout and spacing. Additionally, the SRI hashes are updated to reflect the new build outputs.Component Addition and Integration
locationcomponent SCSS (location.scss) with layout and spacing rules for.chi-location,.chi-location__field, and.chi-location__row.locationcomponent in all theme entry files (index.scss) to ensure it's included in every theme:brightspeed,centurylink,colt,connect,lumen,portal, andtest. [1] [2] [3] [4] [5] [6] [7]Theme Variable Updates
locationcomponent (e.g.,$location-field-add-button-margin,$location-field-display, etc.) in each theme's_variables.scssfile to allow theme-specific customization of the component's layout and spacing. [1] [2] [3] [4] [5] [6] [7]Build and Integrity Updates
sri.jsonto match the new build outputs that include thelocationcomponent and its styles. [1] [2]Other Minor Formatting Improvements
test/_variables.scssfor readability (e.g., box-shadow and calc expressions). [1] [2] [3] [4] [5]