Skip to content

Adds 3DTILES_tile_metadata extension#413

Closed
sanjeetsuhag wants to merge 5 commits intomasterfrom
3DTILES_tile_metadata
Closed

Adds 3DTILES_tile_metadata extension#413
sanjeetsuhag wants to merge 5 commits intomasterfrom
3DTILES_tile_metadata

Conversation

@sanjeetsuhag
Copy link
Contributor

@sanjeetsuhag sanjeetsuhag commented Jun 4, 2020

This extension enables storage of per tile metadata. Specification is available here.

@sanjeetsuhag sanjeetsuhag marked this pull request as draft June 4, 2020 14:37
@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 4, 2020

@sanjeetsuhag congrats on this! Please bump to me when it is ready for me to review. 😄

CC @lilleyse

Copy link
Collaborator

@lilleyse lilleyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The skeleton is good - just needs more detail here and there.

@@ -0,0 +1,161 @@
# 3DTILES_tile_metadata
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about extras.draftVersion as https://github.com/CesiumGS/3d-tiles/pull/414/files#r435609626

@@ -0,0 +1,161 @@
# 3DTILES_tile_metadata
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the next iteration we should include support for arbitrary sized arrays instead of just VEC2, VEC3, VEC4, etc. Same goes for glTF EXT_3dtiles_feature_metadata. It seems like eventually everything's going to conform to the same schema.

@@ -0,0 +1,161 @@
# 3DTILES_tile_metadata
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be padding rules like there are for batch table binary properties: https://github.com/CesiumGS/3d-tiles/tree/master/specification/TileFormats/BatchTable#padding

@sanjeetsuhag sanjeetsuhag changed the title Adds 3DTILES_tile_metadata Adds 3DTILES_tile_metadata extension Jun 8, 2020
@lilleyse
Copy link
Collaborator

Closing, but transferring most of the ideas here to a fresh PR.

@lilleyse lilleyse closed this Sep 22, 2020
@lilleyse lilleyse deleted the 3DTILES_tile_metadata branch September 22, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants