Resolve root tile event when Tileset has invalid loader#1316
Open
Resolve root tile event when Tileset has invalid loader#1316
Tileset has invalid loader#1316Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
getRootTileAvailableEventnever fires if the underlying loader is invalid. This happens in cases where invalid asset IDs are passed in, and the loader rightfully prevents itself from making a bogus request.I ran into this in Unreal because of how statistics work. It requires loading the tileset's metadata schema after the root tile is available. However, if the promise never resolves, then we just keep waiting for something that will never happen. This resulted in the Editor never being able to close a level that was attempting to load inaccessible tileset metadata. Even if no root tile is actually loaded, the event should resolve when it's clear nothing can be loaded (similar to failed URL loads).