Conversation
| #include <vector> | ||
|
|
||
| // OPAQUE is defined in wingdi.h | ||
| #undef OPAQUE |
There was a problem hiding this comment.
this turns out to be quite cumbersome to use the glTF library in O3DE too. I think we should rename the enum to something else (Maybe add prefix gltf to enum)
There was a problem hiding this comment.
or maybe use Opaque as a name with the first letter capitalized (Not entirely fool-proofed for what window does, but seems to be good enough)
There was a problem hiding this comment.
Yeah it's unfortunate. I'm not happy with undef'ing things in Cesium Native so maybe renaming is a better choice. We already do that already for properties that conflict with reserved cpp words, like "class" becomes "clasProperty". Maybe "OPAQUE" could become "OPAQUE_ENUM".
|
All the code generator and cleanup changes are now in #418 so make sure to review that one first. |
This is a follow up to #412 that replaces the current GltfWriter with an autogenerated GltfWriter.
The new writer takes a very hands-off approach. It serializes the CesiumGltf struct as-is without any special handling for external files or data uris. It's expected that the user would manage this on their own before calling
writeGltforwriteGlb. This was to avoid injecting custom code in the autogenerated code or copying or modifying theCesiumGltfstruct that's passed in. The full doc is below.