EXT_mesh_features: Language and clarity updates (continued)#25
Merged
ptrgags merged 2 commits intoCesiumGS:3d-tiles-nextfrom Oct 11, 2021
Merged
Conversation
Notable changes: - Expand raster format description. - Relax byte alignment requirements to match component size, not strictly 8-byte. - Clarify that GPU instancing does not allow property textures at the node level.
|
Looked over the changes as described in #21, looks good! thanks @donmccurdy! |
nithinp7
pushed a commit
that referenced
this pull request
Feb 15, 2022
EXT_mesh_features: Language and clarity updates (continued)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #21.
This PR does not include any (intentional) technical changes, but does specify some restrictions that were probably intended but not previously explicit. I've updated terminology in the illustrations, but haven't altered illustrations much otherwise. I've tried to introduce concepts "in order", but early references to later topics are necessary in a few places and I've tried to include links accordingly.
Written descriptions of properties are not exhaustive — hopefully this is a good balance of providing enough detail without duplicating content from the Core Metadata specification. Each section now links to a schema file, which does include exhaustive property references.