fix: verify_config now checks processors in child process groups#404
Merged
Chaffelson merged 1 commit intomainfrom Jan 18, 2026
Merged
fix: verify_config now checks processors in child process groups#404Chaffelson merged 1 commit intomainfrom
Chaffelson merged 1 commit intomainfrom
Conversation
Previously verify_config filtered processors to only those directly in the root process group, missing processors in child PGs. This caused issues with connectors that have nested process group structures. Also adds --only_failures option to reduce output size for large flows.
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where verify_config only checked processors in the root process group and adds a new feature to filter results to show only failures.
Changes:
- Modified
_verify_processorsto verify processors in all descendant process groups, not just the root PG - Added
only_failuresparameter to optionally filter results to show only failed components - Refactored result building to use a consolidated
all_resultsvariable for cleaner code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 76.65% 76.58% -0.07%
==========================================
Files 41 41
Lines 4780 4780
==========================================
- Hits 3664 3661 -3
- Misses 1116 1119 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously verify_config filtered processors to only those directly in the root process group, missing processors in child PGs. This caused issues with connectors that have nested process group structures.
Also adds --only_failures option to reduce output size for large flows.