This repository was archived by the owner on Nov 7, 2023. It is now read-only.
removes dependency on server world name leading to NPE; fixes #247#249
Open
dzrw wants to merge 1 commit intoChicken-Bones:1.7from
Open
removes dependency on server world name leading to NPE; fixes #247#249dzrw wants to merge 1 commit intoChicken-Bones:1.7from
dzrw wants to merge 1 commit intoChicken-Bones:1.7from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to construct a server's world name in such a way as to cause
NEIClientConfig.loadWorldto raise an IOException and leave theworldvariable set to null. Unfortunately, theloadWorldcallsite is wrapped in a catch-and-swallow style exception handler which causes theworld != nullinvariant to be violated; the bug is ultimately revealed as an NPE duringrenderSlotOverlay.For example, the server-sent world name
../../var/lib/minecraft/worldresults in a malformedsaves/NEIfolder that lacks aremote/HOST~PORTfolder.The fix is to remove this dependency on the server world name, and use a hard-coded name instead. This ought to be safe because a HOST:PORT combination should uniquely identify a world, but this assumption should be reviewed.
I've also added some logging around the assignment of the
worldvariable, so that it will log a more helpful error message if NEI is unable to create this variable in the future for some other reason.