Skip to content

Allow more rows to be used in the keypad #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtornero wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow more rows to be used in the keypad #35

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8e91a2
Update keypad.h to allow bigger matrix
jtornero May 26, 2021
4731aae
Allow more rows to be used in the keypad
jtornero May 26, 2021
4174166
Merge pull request #1 from jtornero/jtornero-patch-mapsize
jtornero May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Keypad.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ typedef struct {
} KeypadSize;

#define LIST_MAX 10 // Max number of keys on the active list.
#define MAPSIZE 10 // MAPSIZE is the number of rows (times 16 columns)
#define MAPSIZE 12 // MAPSIZE is the number of rows (times 16 columns)
#define makeKeymap(x) ((char*)x)


Expand All @@ -81,7 +81,7 @@ class Keypad : public Key {
virtual void pin_write(byte pinNum, boolean level) { digitalWrite(pinNum, level); }
virtual int pin_read(byte pinNum) { return digitalRead(pinNum); }

uint bitMap[MAPSIZE]; // 10 row x 16 column array of bits. Except Due which has 32 columns.
uint bitMap[MAPSIZE]; // 12 row x 16 column array of bits. Except Due which has 32 columns.
Key key[LIST_MAX];
unsigned long holdTimer;

Expand Down