Skip to content

reorganized code to allow inclusion without execution#3

Open
fearphage wants to merge 1 commit intoChris911:masterfrom
fearphage:reorganization
Open

reorganized code to allow inclusion without execution#3
fearphage wants to merge 1 commit intoChris911:masterfrom
fearphage:reorganization

Conversation

@fearphage
Copy link
Contributor

Reorganized code to allow module inclusion without execution. To include and register in one-shot (like before), there's a separate file for that (register.js).

If you accept this PR, you'd need to update the readme file to the following:

mocha -r mocha-http-detect/register

@fearphage
Copy link
Contributor Author

@Chris911 Thoughts on this one?

@Chris911
Copy link
Owner

Chris911 commented Apr 6, 2016

I'm just wondering if there's really a need for this. The module is really simple and I purposely kept everything in one file with a single purpose.

@fearphage
Copy link
Contributor Author

I think it's the opposite. The number of files doesn't imply simplicity. Each file doing one simple thing makes things simple. It's more complex in a programming sense that one file does 10 things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants