reorganized code to allow inclusion without execution#3
Open
fearphage wants to merge 1 commit intoChris911:masterfrom
Open
reorganized code to allow inclusion without execution#3fearphage wants to merge 1 commit intoChris911:masterfrom
fearphage wants to merge 1 commit intoChris911:masterfrom
Conversation
38375a5 to
db5161a
Compare
feaefa6 to
00aa5ea
Compare
Contributor
Author
|
@Chris911 Thoughts on this one? |
Owner
|
I'm just wondering if there's really a need for this. The module is really simple and I purposely kept everything in one file with a single purpose. |
Contributor
Author
|
I think it's the opposite. The number of files doesn't imply simplicity. Each file doing one simple thing makes things simple. It's more complex in a programming sense that one file does 10 things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganized code to allow module inclusion without execution. To include and register in one-shot (like before), there's a separate file for that (
register.js).If you accept this PR, you'd need to update the readme file to the following: