TECH: StringDeduplicator: deduplicate only emptystring by default#42
Open
TECH: StringDeduplicator: deduplicate only emptystring by default#42
Conversation
Collaborator
|
Is this an assumption or baked by data? |
Collaborator
Author
|
It is backed by the fact that loading WatchDAO from dumps yields a DAO that looks smaller, but a StringDeduplicator that is much fatter, so totals are far worse. This is at least part of the reason why heap consumption keeps slowly creeping up over time. |
Collaborator
Author
|
The optimum solution would be to define the behavior through an annotation property, so that fields which profit greatly from content deduplication can make use of it again. For the general case though, we should enforce only scenarios where the win is guaranteed, as with redundant emptystring instances. Plus, for any temporary entities not kept in memory, deduplication means just a waste of additional allocation and gc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything else might be too small to outweigh the overhead, or not even that redundant to begin with. We should provide some other means to decide on a field to field basis when to deduplicate inside de-externalization.