Create Pydantic Based Config Models#82
Draft
legoguy1000 wants to merge 3 commits intoChuckBuilds:mainfrom
Draft
Conversation
Collaborator
Author
|
@ChuckBuilds Let me know if u like this idea. Its gonna take a min to convert everything so I wanted to make sure u like it before I bother. Right now I only have it working with NFL and clock. |
added 2 commits
September 28, 2025 09:23
Owner
|
Fine by me if you think it's worth the effort. I don't have any exposure to this as a concept but am open to improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the config manager to use a pydantic base config. This creates actual models that can then be type hinted and add build in validation. This also removes all the
.get()calls since its no longer a massive dictionary. Much less checks for if something is none since the model will contain every key and can assign defaults. Also the model then becomes the authoritative source for the config object so u can create the template from that and if something is added to the model, it will be ok if not in the json since it will have defaults.