Skip to content

Conversation

@ChuckHend
Copy link
Owner

URL query parameters can get unwieldy, so provide an equivalent way to search using POST w/ json in body.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds POST method support for the /api/v1/search endpoint, allowing clients to submit search parameters via JSON request body instead of URL query parameters. This provides a more ergonomic API for complex filter objects.

  • Added SearchRequestPOST struct and search_json endpoint handler for POST requests
  • Refactored search logic into shared search_internal function used by both GET and POST
  • Updated documentation to explain both GET and POST usage patterns with examples

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
server/src/routes/search.rs Added POST endpoint with SearchRequestPOST struct, refactored shared logic into search_internal
server/src/server.rs Registered new search_json route handler
server/tests/tests.rs Added test coverage for POST search endpoint with filters
docs/server/api/search.md Updated documentation to cover both GET and POST methods with examples
core/src/query.rs Fixed punctuation in error message (added period)
core/src/init.rs Changed vec! to array literal and removed format! macro call
.gitignore Added .vscode directory to gitignore

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ChuckHend ChuckHend marked this pull request as ready for review November 3, 2025 13:40
@ChuckHend ChuckHend merged commit 1f48de6 into main Nov 3, 2025
5 checks passed
@ChuckHend ChuckHend deleted the search-p branch November 3, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants