Add monthly recurrence out-of-bounds day handling #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating monthly recurrences with days that don't exist in all months (e.g., 31st in April), callers can now specify a strategy via CreateRecurrenceOptions: - Throw (default): Throws MonthDayOutOfBoundsException with affected months - Skip: Skips months where the day doesn't exist - Clamp: Uses the last day of short months Introduces strategy pattern for occurrence generation with IOccurrenceGenerator, IcalNetOccurrenceGenerator (for Skip), and ClampedMonthlyOccurrenceGenerator (for Clamp). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CreateRecurrenceOptionsparameter toCreateRecurrenceAsyncwithOutOfBoundsMonthBehaviorsettingMonthDayOutOfBoundsStrategyenum:Throw(default),Skip,ClampMonthDayOutOfBoundsExceptioncontaining affected months whenThrowstrategy is usedIOccurrenceGeneratorinterfaceMonthDayBehaviorfield toRecurrencedomain entity and database schemasDetails
When creating monthly recurrences with days that don't exist in all months (e.g., 31st in April, June, September, November; or 29th/30th/31st in February), the caller can now specify how to handle these cases:
MonthDayOutOfBoundsExceptionwithAffectedMonthslist, allowing the caller to prompt the userNew Files
src/RecurringThings/Options/MonthDayOutOfBoundsStrategy.cssrc/RecurringThings/Options/CreateRecurrenceOptions.cssrc/RecurringThings/Exceptions/MonthDayOutOfBoundsException.cssrc/RecurringThings/Engine/Virtualization/IOccurrenceGenerator.cssrc/RecurringThings/Engine/Virtualization/IcalNetOccurrenceGenerator.cssrc/RecurringThings/Engine/Virtualization/ClampedMonthlyOccurrenceGenerator.cssrc/RecurringThings/Engine/Virtualization/OccurrenceGeneratorFactory.cssrc/RecurringThings.PostgreSQL/Migrations/20260127200000_AddMonthDayBehavior.cstests/RecurringThings.Tests/Engine/RecurrenceEngineMonthlyBoundsTests.csTest plan
dotnet format🤖 Generated with Claude Code