Skip to content

fix: logo now redirects to main circuitverse.org domain (#6437) #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vivekyadav-3 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: logo now redirects to main circuitverse.org domain (#6437) #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions layouts/partials/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
<header class="fixed-top navigation">
<div class="container">
<!-- navbar -->
<nav class="navbar px-0 navbar-expand-lg navbar-light bg-transparent">
<a class="navbar-brand" href="https://circuitverse.org/">
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL is hardcoded, which makes the template less flexible and harder to maintain. Consider making this configurable by adding a parameter to config.toml (e.g., params.main_site_url or params.logo_url) and then reference it here with {{ .Site.Params.main_site_url }}. This would allow for easier configuration changes without modifying template files, which is a Hugo best practice.

Suggested change
<a class="navbar-brand" href="https://circuitverse.org/">
<a class="navbar-brand" href="{{ .Site.Params.main_site_url | default "https://circuitverse.org/" }}">

Copilot uses AI. Check for mistakes.
<img
class="img-fluid"
src="{{ .Site.Params.logo | relURL }}"
alt="{{ .Site.Title }}"
/>
</a>
<button
class="navbar-toggler border-0 px-0"
type="button"
data-toggle="collapse"
data-target="#navigation"
>
<i class="ti-menu text-dark h3"></i>
</button>
Comment on lines +12 to +19
Copy link

@coderabbitai coderabbitai bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# Check for Bootstrap version in configuration files
fd -e json -e toml -e yaml -e mod -e lock -e txt | head -20

Repository: CircuitVerse/Blog

Length of output: 85

🏁 Script executed:

# Search for Bootstrap version references in common config files
find . -maxdepth 3 \( -name "package.json" -o -name "go.mod" -o -name "config.toml" -o -name "config.yaml" -o -name "theme.toml" \) -type f -exec cat {} \; 2>/dev/null

Repository: CircuitVerse/Blog

Length of output: 3242

🏁 Script executed:

# Check for data-toggle vs data-bs-toggle usage in the codebase
rg 'data-toggle|data-bs-toggle' --type html -c

Repository: CircuitVerse/Blog

Length of output: 91

🏁 Script executed:

# Search for Bootstrap imports or version indicators
rg 'bootstrap' --type json --type toml --type yaml -A 2 -B 2

Repository: CircuitVerse/Blog

Length of output: 499

🏁 Script executed:

# Check Bootstrap version from actual plugin files
fd -type f -path "*/plugins/bootstrap/*" | head -20

Repository: CircuitVerse/Blog

Length of output: 231

🏁 Script executed:

# Try to find version info in Bootstrap files
find . -path "*/plugins/bootstrap/*" -type f \( -name "*.css" -o -name "*.js" \) | head -5 | xargs head -20 2>/dev/null

Repository: CircuitVerse/Blog

Length of output: 43

🏁 Script executed:

# Check the header.html file to see full context and all data-toggle usages
cat -n layouts/partials/header.html | head -40

Repository: CircuitVerse/Blog

Length of output: 1644

🏁 Script executed:

# Check Bootstrap version from the CSS file header or first lines
head -100 plugins/bootstrap/bootstrap.min.css 2>/dev/null | grep -o "Bootstrap v[0-9.]*" | head -1

Repository: CircuitVerse/Blog

Length of output: 43

🏁 Script executed:

# Alternative: check for Bootstrap version in CSS or JS comments
find . -path "*/plugins/bootstrap/*" \( -name "*.css" -o -name "*.js" \) -exec head -5 {} + 2>/dev/null

Repository: CircuitVerse/Blog

Length of output: 43

🏁 Script executed:

# Search for version strings in package dependencies or lockfiles
find . -maxdepth 3 -type f \( -name "package-lock.json" -o -name "yarn.lock" -o -name ".versions" \) 2>/dev/null

Repository: CircuitVerse/Blog

Length of output: 43

🏁 Script executed:

# Try to find Bootstrap files with a different approach
find . -name "bootstrap.min.css" -o -name "bootstrap.min.js" 2>/dev/null

Repository: CircuitVerse/Blog

Length of output: 43

🏁 Script executed:

# Check if files exist and get their content
ls -lh plugins/bootstrap/ 2>/dev/null

Repository: CircuitVerse/Blog

Length of output: 43

🏁 Script executed:

# Search for any README or version files
find plugins/bootstrap/ -type f 2>/dev/null

Repository: CircuitVerse/Blog

Length of output: 43

🏁 Script executed:

# List all files in the repository to understand structure
git ls-files | head -40

Repository: CircuitVerse/Blog

Length of output: 1225

🏁 Script executed:

# Search for any minified bootstrap files anywhere
find . -name "*bootstrap*" 2>/dev/null

Repository: CircuitVerse/Blog

Length of output: 43

🏁 Script executed:

# Check if there's a theme subdirectory with Bootstrap
find . -path "*northendlab*" -o -path "*theme*" 2>/dev/null | head -20

Repository: CircuitVerse/Blog

Length of output: 177

🏁 Script executed:

# Check Bootstrap files in the theme directory
find themes/northendlab-hugo -name "*bootstrap*" -type f 2>/dev/null

Repository: CircuitVerse/Blog

Length of output: 43

🏁 Script executed:

# Check the theme's config or README for Bootstrap version info
ls -la themes/northendlab-hugo/ 2>/dev/null

Repository: CircuitVerse/Blog

Length of output: 167

🏁 Script executed:

# Look at the header.html in the theme directly
cat themes/northendlab-hugo/layouts/partials/header.html | head -50

Repository: CircuitVerse/Blog

Length of output: 145

🏁 Script executed:

# Check for Bootstrap version in the theme's plugins or static files
find themes/northendlab-hugo -type f -name "*.css" -o -name "*.js" | grep -i bootstrap | head -10

Repository: CircuitVerse/Blog

Length of output: 43

🏁 Script executed:

# Check .gitmodules to see if theme is a git submodule
cat .gitmodules 2>/dev/null

Repository: CircuitVerse/Blog

Length of output: 185

🏁 Script executed:

# Check the theme directory status
git ls-files | grep themes/

Repository: CircuitVerse/Blog

Length of output: 84

🏁 Script executed:

# The layouts directory is at the root, not in theme. Let's verify the structure
ls -la layouts/partials/ | head -20

Repository: CircuitVerse/Blog

Length of output: 232

🏁 Script executed:

# Check if there are any bootstrap files in static or assets
find . -name "*bootstrap*" -type f 2>/dev/null | head -20

Repository: CircuitVerse/Blog

Length of output: 43

🌐 Web query:

northendlab-hugo theme Bootstrap version

💡 Result:

The NorthendLab Hugo theme uses Bootstrap v4.5.0 (noted in the theme’s changelog for v1.0.0, released March 7, 2021). [1]

Sources:
[1] (gethugothemes.com)

Citations:

Add accessibility attributes to hamburger toggle button.

The icon-only button lacks aria-label, aria-controls, and aria-expanded attributes. Screen readers will not announce its purpose or state.

Suggested fix 
      <button
        class="navbar-toggler border-0 px-0"
        type="button"
        data-toggle="collapse"
        data-target="#navigation"
+       aria-label="Toggle navigation"
+       aria-controls="navigation"
+       aria-expanded="false"
      >
        <i class="ti-menu text-dark h3"></i>
      </button>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<button
class="navbar-toggler border-0 px-0"
type="button"
data-toggle="collapse"
data-target="#navigation"
>
<i class="ti-menu text-dark h3"></i>
</button>
<button
class="navbar-toggler border-0 px-0"
type="button"
data-toggle="collapse"
data-target="#navigation"
aria-label="Toggle navigation"
aria-controls="navigation"
aria-expanded="false"
>
<i class="ti-menu text-dark h3"></i>
</button>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@layouts/partials/header.html` around lines 12 - 19, The hamburger toggle
button (the element with class "navbar-toggler" that targets "#navigation") is
missing accessibility attributes; update the button to include
aria-label="Toggle navigation", aria-controls="navigation", and an initial
aria-expanded="false" so screen readers announce its purpose and controlled
region, and ensure the collapse behavior (Bootstrap/JS that manages the
"#navigation" collapse) updates aria-expanded as the menu opens and closes.


<div class="collapse navbar-collapse text-center" id="navigation">
<ul class="navbar-nav ml-auto">
Copy link

@accesslint accesslint bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WCAG 1.3.1:

    contains direct text content. Wrap in
  • .

      and
        must only contain
      1. , <script>, or as direct children.
        Details

        Screen readers announce list structure ('list with 5 items') based on proper markup. Placing non-

      2. elements directly inside
          or
            breaks this structure. Wrap content in
          1. elements, or if you need wrapper divs for styling, restructure your CSS to style the
          2. elements directly.

<li class="nav-item">
<a class="nav-link" href="{{ .Site.BaseURL }}"
>{{ with .Site.Params.Home }} {{ . }} {{ end }}</a
>
</li>
{{ range .Site.Menus.main }} {{ if .HasChildren }}
<li class="nav-item dropdown">
<a
class="nav-link dropdown-toggle"
href="#"
role="button"
data-toggle="dropdown"
aria-haspopup="true"
aria-expanded="false"
>
{{ .Name }}
</a>
<div class="dropdown-menu">
{{ range .Children }}
<a class="dropdown-item" href="{{ .URL | absURL }}"
>{{ .Name }}</a
>
{{ end }}
</div>
</li>
{{ else }}
<li class="nav-item">
<a class="nav-link" href="{{ .URL | absURL }}">{{ .Name }}</a>
</li>
{{ end }} {{ end }}
</ul>
{{ if .Site.Params.search.enable }} {{ "<!-- search -->" | safeHTML }}
<div class="search">
<button id="searchOpen" class="search-btn">
Copy link

@accesslint accesslint bot Feb 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WCAG 4.1.2: Button has no discernible text.

Buttons must have discernible text.

Details

Classes: search-btn

Screen reader users need to know what a button does. Add visible text content, aria-label, or aria-labelledby. For icon buttons, use aria-label describing the action (e.g., aria-label='Close'). If the button contains an image, ensure the image has alt text describing the button's action.

Also on line 69.

<i class="ti-search"></i>
</button>
<div class="search-wrapper">
<form action="{{ `search` | absURL }}" class="h-100">
<input
class="search-box px-4"
id="search-query"
name="s"
type="search"
placeholder="Type & Hit Enter..."
/>
</form>
<button id="searchClose" class="search-close">
Copy link

@accesslint accesslint bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WCAG 4.1.2: Button has no discernible text.

<i class="ti-close text-dark"></i>
</button>
Comment on lines +56 to +71
Copy link

@coderabbitai coderabbitai bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Icon-only search buttons are missing aria-label; unescaped & in placeholder.

Two issues:

  1. Both #searchOpen and #searchClose buttons are icon-only with no accessible name, identical to the hamburger problem above.
  2. Line 66: placeholder="Type & Hit Enter..." — the bare & is technically invalid HTML (should be &amp;). Browsers tolerate it, but it will fail HTML validation.
🛡️ Proposed fix 
           <button id="searchOpen" class="search-btn">
-            <i class="ti-search"></i>
+            <i class="ti-search" aria-hidden="true"></i>
+            <span class="sr-only">Open search</span>
           </button>
               <input
                 class="search-box px-4"
                 id="search-query"
                 name="s"
                 type="search"
-                placeholder="Type & Hit Enter..."
+                placeholder="Type &amp; Hit Enter..."
               />
             <button id="searchClose" class="search-close">
-              <i class="ti-close text-dark"></i>
+              <i class="ti-close text-dark" aria-hidden="true"></i>
+              <span class="sr-only">Close search</span>
             </button>
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@layouts/partials/header.html` around lines 56 - 71, Add accessible names to
the icon-only buttons by adding descriptive aria-label attributes to the
elements with id "searchOpen" and "searchClose" (e.g., aria-label="Open search"
and aria-label="Close search") and replace the unescaped ampersand in the input
with an HTML entity (change the placeholder on element id "search-query" from
"Type & Hit Enter..." to use "&amp;") so the buttons are accessible and the HTML
validates.

</div>
</div>
{{ end }}
</div>
</nav>
</div>
</header>
Loading