cml_node | allow prepopulating interfaces before node is started#45
Open
tvarohohlavy wants to merge 1 commit intoCiscoDevNet:mainfrom
Open
cml_node | allow prepopulating interfaces before node is started#45tvarohohlavy wants to merge 1 commit intoCiscoDevNet:mainfrom
tvarohohlavy wants to merge 1 commit intoCiscoDevNet:mainfrom
Conversation
tvarohohlavy
force-pushed
the
node_populate_interfaces
branch
from
6431697 to
6552a51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this when we create nodes and not start them we cannot create links as nodes do not have any interfaces pre-created.
It uses existing parameter in Lab.create_node() as visible here:
https://github.com/CiscoDevNet/virl2-client/blob/af60c0b53345937d92402a8c114f9ceca7377a94/virl2_client/models/lab.py#L577-L599
Default behavior of virl2-client is to not prepopulate, default behavior of UI is to prepopulate.
As current behavior was to not prepopulate I have kept it as default.