cml_node | add missing absent state handling#47
Open
tvarohohlavy wants to merge 1 commit intoCiscoDevNet:mainfrom
Open
cml_node | add missing absent state handling#47tvarohohlavy wants to merge 1 commit intoCiscoDevNet:mainfrom
tvarohohlavy wants to merge 1 commit intoCiscoDevNet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cml_node module has an absent state option which was not implemented
to make this idempotent compared to state changes (started, stopped, wiped) this state also makes sure node is stopped (if running) and wiped (if not wiped yet) before it is deleted as otherwise CML would throw an error.
Usage of wait is preferred to make sure some delay introduced does not prevent all steps: started > stopped > wiped > removed
Examples: