Feat/existing secret #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be interested in this as well. Our current workaround is to use ESO (external secrets operator) to override the secret created by the helm release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request adds an extra field in the values.yaml
controllerInfo.existingSecretwhich can be set as true or false. It then wraps around the creation of thecluster-agent-secretsecret. If set as true, then the secret template will not be processed and a secret will not be created.Why
The current solution for using an existing secret does not work well with ArgoCD, as the lookup feature is not supported by Argo.
How
Bypassing the lookup using the new field, solves the issue without affecting existing functionality.