Added vJUNOS and vROUTER node definitions.#57
Merged
tombry merged 72 commits intoCiscoDevNet:masterfrom Jun 27, 2025
Merged
Conversation
adding palo alto node and image definition
Created readme for Windows 10 node definition
Fixed Windows Server 2019 node definition
fixed video model
xorrkaz
requested changes
Feb 28, 2025
Collaborator
xorrkaz
left a comment
xorrkaz
left a comment
There was a problem hiding this comment.
Can you rebase this on HEAD and push again without the nd_validation change?
Contributor
Author
|
I have synced the fork again, please check now. |
Collaborator
Thanks. I had a typo in my check. Please re-sync and push again. |
tombry
approved these changes
Jun 27, 2025
Collaborator
tombry
left a comment
tombry
left a comment
There was a problem hiding this comment.
Approving this PR since Joe is on vacation. There weren't any changes since Joe last approved: just a resync and push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added vJUNOS and vROUTER node definitions with SMBIOS Parameters and extract configuration function.