Skip to content

Improvements in Lume setup#605

Open
oscarotero wants to merge 13 commits intoCloudCannon:mainfrom
oscarotero:main
Open

Improvements in Lume setup#605
oscarotero wants to merge 13 commits intoCloudCannon:mainfrom
oscarotero:main

Conversation

@oscarotero
Copy link

Hi. Congrats for the new site!

This is a list of improvements for the Lume configuration. I tried to divide the changes into different commits, so it's easy to revert something if you don't like it.

  • I've updated Lume to the latest version. The flag --v8-flags=--max-old-space-size=8192 is no longer needed since Lume 3 is faster and consume less memory than v1. The new version uses Deno's permissions in the deno.json file, which makes the build safer.
  • Lume 3 has a debug bar that you can see if you move the cursor to the bottom of the window. It provides useful info like how many time takes every step in the build process (loading pages, each preprocessor, rendering, procesors, etc). So I removed your custom timing. But I can revert this change if you want.
  • I have changed the dest folder to output the site to _site/documentation but configured the server to use the parent folder as the server's root. The preprocessor to change the URL of all pages to prepend the directory is no longer needed.
  • I made other minor changes, like typescript improvements.

That's all. Thanks for keep using Lume and let me know if you have questions or need to revert something

@EllaCloudCannon
Copy link
Contributor

Thanks @oscarotero !

@georgephillips
Copy link
Contributor

Hey @oscarotero, thanks for the contribution! I have tidying up a few items on this PR:

  1. I fixed the warnings that now show up when we build 🙌
  2. There were a few places still expecting the /documentation in the url from lume.
  3. Fix lint errors and fixed the types for the new versions

I have a few remaining items still to look at before I can merge:

  1. Pagefind is erroring with the new version:
    ERROR [pagefind plugin] Failed to add Component UI files: TypeError: Must be a file URL
    
  2. Table of contents blocks are no longer working
  3. Some active link highlighting is not working in the main nav.
  4. Some JS has stopped working, including the dark light toggle

I will get these tidied up soon and we can get these merged in. Thanks again.

@oscarotero
Copy link
Author

No problem @georgephillips
Let me know if you need help with any of the remaining items!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants