Open
Conversation
…m in the debugbar
Contributor
|
Thanks @oscarotero ! |
Contributor
|
Hey @oscarotero, thanks for the contribution! I have tidying up a few items on this PR:
I have a few remaining items still to look at before I can merge:
I will get these tidied up soon and we can get these merged in. Thanks again. |
Author
|
No problem @georgephillips |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. Congrats for the new site!
This is a list of improvements for the Lume configuration. I tried to divide the changes into different commits, so it's easy to revert something if you don't like it.
--v8-flags=--max-old-space-size=8192is no longer needed since Lume 3 is faster and consume less memory than v1. The new version uses Deno's permissions in the deno.json file, which makes the build safer.destfolder to output the site to_site/documentationbut configured the server to use the parent folder as the server's root. The preprocessor to change the URL of all pages to prepend the directory is no longer needed.That's all. Thanks for keep using Lume and let me know if you have questions or need to revert something