sync with pacemakerd #106
Closed
sync with pacemakerd #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgaillot
reviewed
Dec 12, 2019
src/sbd-pacemaker.c
Outdated
| admin_uuid); | ||
|
|
||
| crm_ipc_send(pacemakerd_channel, cmd, 0, 0, NULL); | ||
| free_xml(cmd); |
There was a problem hiding this comment.
This is the meat of the new API right here :) Then the scaffolding is 10 times as much. I would think we just need a pacemakerd client object with connect, disconnect, and ping methods, and new/free functions for that. Not sure what the naming should look like.
State query ping of pacemakerd prevents pacemakerd from starting any sub-daemons (and thus services) if sbd can't reach it via ipc. As a health-check get timestamp from pacemakerd. On shudown fetch info about graceful shutdown from pacemakerd.
wenningerk
force-pushed
the
sync_with_pacemakerd
branch
from
54c910b to
1d5ecab
Compare
Author
|
Now using pacemakerd-api. |
Use new pacemakerd-api provided by pacemaker.
wenningerk
force-pushed
the
sync_with_pacemakerd
branch
from
2ca7e4d to
d839240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart on pacemaker-side is ClusterLabs/pacemaker#1957
Send a ping to pacemakerd to make it start all the subdaemons.
Periodically send a ping and memorize which timestamp pacemakerd
sent marking that subdaemons were alright.
If this timestamp becomes older than watchdog_timeout stop
triggering the inquisitor.
When pacemakerd-pinging returns shutdown-completed assume all
resources are down and exit pacemaker-watcher gracefully.