Add perf profiling to tinybench#51
Conversation
e18965c to
2a7d48a
Compare
CodSpeed Instrumentation Performance ReportMerging #51 will degrade performances by 84.69%Comparing Summary
Benchmarks breakdown
|
CodSpeed WallTime Performance ReportMerging #51 will degrade performances by 50%Comparing Summary
Benchmarks breakdown
|
2a7d48a to
012d605
Compare
b4b71ef to
5ef7f44
Compare
5ef7f44 to
079d5f2
Compare
079d5f2 to
f070d03
Compare
69ecc14 to
0703b06
Compare
art049
left a comment
There was a problem hiding this comment.
Do we need that much duplication between instrumented.ts and walltime.ts? Since we already have unavoidable duplication between sync and async, it gets a bit hard to verify the logic
e55aee6 to
29f65e9
Compare
29f65e9 to
d9c546a
Compare
I've adressed this in d9c546a This commit also removes the |
d9c546a to
91a7670
Compare
|
@art049 the x1000 in instrumented runs are fixed. We were actually measuring the garbage collector call because of a refactoring error. Changes look more in line with what's expected now |
This is not used yet, but keeping the implementation just in case. If untouched for a long time, do not hesitate to remove
…e if not disabled
91a7670 to
92756b8
Compare
Support is still far from perfect for async/heavy code.
f052c13 to
9575172
Compare
7ee6021 to
e31ee8b
Compare

https://github.com/CodSpeedHQ/codspeed-node/pull/51/files#diff-37f58390c47ed415f315435a8b448d14d00f4fb914e205d86410d694c3215d94R28-R38
Explains the 4 added walltime benches (fixes a bug where only last bench result of a bid was written to json)