feat: parse go bench results using go test#101
Closed
not-matthias wants to merge 6 commits intomainfrom
Closed
Conversation
95dae9c to
1a62b5a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for parsing Go benchmark results by capturing stdout from go test -json commands and converting the output to walltime benchmark format. The implementation includes JSON parsing of Go test output, statistical analysis of benchmark data, and creation of results files.
- Captures and parses
go test -jsonoutput to extract benchmark measurements - Adds statistical analysis and outlier detection for benchmark timing data
- Creates structured JSON results files in
results/{pid}.jsonformat
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/run/runner/wall_time/mod.rs | Adds golang module to wall_time runner |
| src/run/runner/wall_time/perf/mod.rs | Updates to handle new return type from command runner |
| src/run/runner/wall_time/golang/mod.rs | Main entry point for Go benchmark result collection |
| src/run/runner/wall_time/golang/parser.rs | Parses Go test JSON output and extracts benchmark data |
| src/run/runner/wall_time/golang/walltime_results.rs | Statistical analysis and result formatting for benchmarks |
| src/run/runner/wall_time/executor.rs | Integrates Go test parsing into wall time executor |
| src/run/runner/helpers/run_command_with_log_pipe.rs | Adds stdout capture capability to command runner |
| Cargo.toml | Adds statrs dependency for statistical calculations |
| .gitattributes | Configures LFS tracking for test data files |
1a62b5a to
ac4c59d
Compare
Member
Author
|
This is not relevant anymore, we're doing the more advanced approach with our custom go runner. See #102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
go test -jsonoutputresults/{pid}.jsonCan be used like this (users have to specify the benchtime and count fow now):
Example run: https://staging.codspeed.io/AvalancheHQ/fuego/runs/6882013bc8c28e8027e3f46a