Skip to content

Cod 1248 address warnings in benchmark steps of GitHub actions #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
not-matthias merged 2 commits into from
Aug 25, 2025
Merged

Cod 1248 address warnings in benchmark steps of GitHub actions #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea474e1
fix: dont show error when libpython is not found
not-matthias Aug 25, 2025
5c6d90a
chore: change log level to warn for venv_compat error
not-matthias Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/run/runner/valgrind/executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ impl Executor for ValgrindExecutor {
install_valgrind(system_info).await?;

if let Err(error) = venv_compat::symlink_libpython(None) {
error!("Failed to symlink libpython: {error}");
} else {
info!("Successfully added symlink for libpython in the venv");
warn!("Failed to symlink libpython");
debug!("Script error: {error}");
}

Ok(())
Expand Down
4 changes: 2 additions & 2 deletions src/run/runner/valgrind/helpers/venv_compat.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function add_symlink() {
system_python="$(readlink -f "$venv_python")"
if [ -z "$system_python" ]; then
echo "Error: Failed to resolve real path for $venv_python" >&2
return 1
return 0
fi

system_path="$(dirname $(dirname "$system_python"))"
Expand All @@ -17,7 +17,7 @@ function add_symlink() {
libpython_name="$(ldd "$venv_python" 2>/dev/null | grep -o -m1 'libpython[^[:space:]]*' || true)"
if [ -z "$libpython_name" ]; then
echo "Error: exact libpython name not found in $(ldd $venv_python)" >&2
return 1
return 0
fi
echo "Found linked libpython: $libpython_name"

Expand Down
Loading