feat: allow wider range of valgrind codspeed version usage#137
Merged
Conversation
9d785f5 to
36cb3ba
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the valgrind version checking logic to allow the runner to work with newer versions of valgrind-codspeed, rather than requiring an exact version match. The implementation uses semantic versioning to ensure backward compatibility while warning about experimental newer versions.
Key Changes:
- Replaced string-based version checking with semantic version comparison using the
semvercrate - Changed version check from exact match to minimum version requirement
- Added version parsing logic that handles various valgrind version string formats
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/run/runner/valgrind/setup.rs | Implements semantic version parsing and comparison logic for valgrind versions, replacing exact string matching with minimum version requirements |
| src/main.rs | Converts valgrind version constants from strings to semver Version type and introduces separate display string |
| Cargo.toml | Adds semver dependency for semantic version handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
e23e87f to
2b2dad8
Compare
2b2dad8 to
c904fd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it possible to use newer builds of valgrind codspeed with an older runner