fix: fail if memtrack isn't supported#195
Merged
not-matthias merged 2 commits intomainfrom Jan 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the FIFO command handling to allow executor-specific overrides of commands before falling back to shared implementation. It adds version checking in the memory executor to fail early if the integration doesn't support memory profiling (protocol version < 2).
Changes:
- Refactored
handle_fifo_messagesto use a two-stage approach: executor-specific handler first, then shared implementation - Added protocol version check in memory executor to enforce minimum version 2 requirement
- Updated return type from
FifoCommandtoOption<FifoCommand>for the handler callback
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/executor/shared/fifo.rs | Refactored command handling to invoke custom handler first, then fall back to shared implementation; added default error response for unhandled commands |
| src/executor/wall_time/perf/mod.rs | Updated perf executor to return Option<FifoCommand> and removed duplicate error handling |
| src/executor/memory/executor.rs | Added SetVersion command handler to check for minimum protocol version 2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GuillaumeLagrange
requested changes
Jan 19, 2026
Contributor
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
tests are failing, not sure why, ping me for quick re-review
0a8c23d to
f22e5a2
Compare
f22e5a2 to
d706f21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked the shared FIFO handler to first run
handle_cmdwhich allows overriding the commands. Then added a check in SetVersion to check for minimum required version