Cod 870 implement landrun adapted runner commands#81
Merged
GuillaumeLagrange merged 1 commit intomainfrom May 20, 2025
Merged
Conversation
not-matthias
approved these changes
May 14, 2025
Member
not-matthias
left a comment
not-matthias
left a comment
There was a problem hiding this comment.
It took me quite some time to realize that upload_only means. I think a better name for it would be skip_run since we already have skip_setup and skip_upload. And that would also make the purpose more obvious.
Apart from the naming, everything else looks good! 👍
GuillaumeLagrange
force-pushed
the
cod-870-implement-landrun-adapted-runner-commands
branch
from
de7e59b to
36ac0ba
Compare
GuillaumeLagrange
deleted the
cod-870-implement-landrun-adapted-runner-commands
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to allow running commands in a sandbox with no network access