Skip to content

feat: add cpu isolation for system, perf and benchmark#86

Merged
not-matthias merged 1 commit intomainfrom
cod-588-further-macro-runner-improvements
Jun 16, 2025
Merged

feat: add cpu isolation for system, perf and benchmark#86
not-matthias merged 1 commit intomainfrom
cod-588-further-macro-runner-improvements

Conversation

@not-matthias
Copy link
Member

No description provided.

@not-matthias not-matthias force-pushed the cod-588-further-macro-runner-improvements branch from 2e7ce50 to 94142ae Compare June 5, 2025 09:56
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two subsequent questions:

  1. Did you try the effect of existing walltime benchmarks ? We may need to prepare users for breaking changes on this regard.

  2. How does this behave when the user is not root on the machine ? (Edge case obviously since macro runners are not concerned)

@not-matthias not-matthias force-pushed the cod-588-further-macro-runner-improvements branch 4 times, most recently from f3512d5 to 03054f5 Compare June 5, 2025 16:36
@not-matthias
Copy link
Member Author

Did you try the effect of existing walltime benchmarks ? We may need to prepare users for breaking changes on this regard.

Not yet. Will do that tomorrow on an AWS EC2 instance.

How does this behave when the user is not root on the machine ? (Edge case obviously since macro runners are not concerned)

We already need root to install perf/valgrind if it's not installed. I made sure that the command can be run without root, which is the reason why we can't use systemd-run with a custom slice that pins the bench process to a specific core. We would have to run it with systemd-run --user which puts it into the user.slice.

@not-matthias not-matthias force-pushed the cod-588-further-macro-runner-improvements branch 5 times, most recently from a818fdc to 170795a Compare June 10, 2025 13:52
@not-matthias not-matthias force-pushed the cod-588-further-macro-runner-improvements branch from 170795a to d4c38cb Compare June 16, 2025 10:29
Copy link
Contributor

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@not-matthias not-matthias merged commit d4c38cb into main Jun 16, 2025
9 checks passed
@not-matthias not-matthias deleted the cod-588-further-macro-runner-improvements branch June 16, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments