fix: only show perf output at debug or trace level#87
Merged
not-matthias merged 1 commit intomainfrom Jun 11, 2025
Merged
Conversation
art049
reviewed
Jun 10, 2025
Member
art049
left a comment
art049
left a comment
There was a problem hiding this comment.
can't we redirect the output to a log file we could send in the archive instead?
I think we're doing this with valgrind already: https://github.com/CodSpeedHQ/runner/blob/cbe1d74ed11ca205464595bae1a59e76a3754565/src/run/runner/valgrind/measure.rs#L107-L117
Member
Author
Unfortunately there's no CLI argument that allows redirecting the output to a file (see man page for perf-record) |
art049
approved these changes
Jun 11, 2025
not-matthias
force-pushed
the
cod-979-redirect-perf-logs-to-file
branch
from
7073896 to
924ea15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.