Skip to content

fix: dwarf unwinding #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
not-matthias merged 2 commits into from
Jun 26, 2025
Merged

fix: dwarf unwinding #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc3e08b
fix: use correct path for unwind info
not-matthias Jun 12, 2025
5aa4152
chore: add debug logs for proc maps
not-matthias Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 27 additions & 13 deletions src/run/runner/wall_time/perf/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ impl PerfRunner {

let bench_proc = procfs::process::Process::new(pid as _)
.expect("Failed to find benchmark process");
let exe_path = bench_proc.exe().expect("Failed to read /proc/{pid}/exe");
let exe_maps = bench_proc.maps().expect("Failed to read /proc/{pid}/maps");

for map in &exe_maps {
Expand All @@ -237,24 +236,39 @@ impl PerfRunner {
_ => None,
};

if let Some(path) = path {
if let Some(path) = &path {
symbols_by_pid
.entry(pid)
.or_insert(ProcessSymbols::new(pid))
.add_mapping(pid, &path, base_addr, end_addr);
.add_mapping(pid, path, base_addr, end_addr);
debug!("Added mapping for module {:?}", path);
}

if map.perms.contains(MMPermissions::EXECUTE) {
if let Ok(unwind_data) = UnwindData::new(
exe_path.to_string_lossy().as_bytes(),
page_offset,
base_addr,
end_addr - base_addr,
None,
) {
unwind_data_by_pid.entry(pid).or_default().push(unwind_data);
if map.perms.contains(MMPermissions::EXECUTE) {
match UnwindData::new(
path.to_string_lossy().as_bytes(),
page_offset,
base_addr,
end_addr - base_addr,
None,
) {
Ok(unwind_data) => {
unwind_data_by_pid
.entry(pid)
.or_default()
.push(unwind_data);
debug!("Added unwind data for {path:?} ({base_addr:x} - {end_addr:x})");
}
Err(error) => {
debug!(
"Failed to create unwind data for module {}: {}",
path.display(),
error
);
}
}
}
} else if map.perms.contains(MMPermissions::EXECUTE) {
debug!("Found executable mapping without path: {base_addr:x} - {end_addr:x}");
}
}
}
Expand Down
Loading