Cod 1008 benchmark run fails on macro runner with systemd run#89
Merged
not-matthias merged 5 commits intomainfrom Jun 30, 2025
Merged
Conversation
not-matthias
force-pushed
the
cod-1008-benchmark-run-fails-on-macro-runner-with-systemd-run
branch
2 times, most recently
from
9da248d to
4a524d8
Compare
not-matthias
force-pushed
the
cod-1008-benchmark-run-fails-on-macro-runner-with-systemd-run
branch
4 times, most recently
from
80f06b3 to
2f2cb0d
Compare
art049
approved these changes
Jun 30, 2025
not-matthias
force-pushed
the
cod-1008-benchmark-run-fails-on-macro-runner-with-systemd-run
branch
2 times, most recently
from
cb30b27 to
0fa16ae
Compare
Most of the changes are related to formatting and moving variables into `println` or log stmts. They have been automatically converted using `cargo fmt`, `cargo fix` and `cargo clippy fix`
not-matthias
force-pushed
the
cod-1008-benchmark-run-fails-on-macro-runner-with-systemd-run
branch
from
0fa16ae to
8a9c894
Compare
not-matthias
force-pushed
the
cod-1008-benchmark-run-fails-on-macro-runner-with-systemd-run
branch
from
8a9c894 to
0578848
Compare
art049
approved these changes
Jun 30, 2025
not-matthias
deleted the
cod-1008-benchmark-run-fails-on-macro-runner-with-systemd-run
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 1: Turns out that runuser doesn't work without
sudoin the macro-runner:I decided to use the
uidandgidparameters insystemd-runsince we don't have to rely on runuser in that case.Fix 2: We also have to pass the environment variables to the process, since the benchmarks are running with systemd.
Fix 3: Perf can't trace a process that's running with root privileges. We have to run perf with root, which makes the child processes also run with root. I also updated the splitting, since we can't kill a root process, from a non-root process.
EDIT: @art049 should've waited with the merge, the last 3 commits aren't related to this PR (they are from the other one that was stacked on top of this one). Please ignore them since the review was already done